Skip to content

fix: Manully validate StreamPorts in StreamConfig to prevent empty values #11332

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
zhengkunwang223 merged 1 commit into from
Dec 15, 2025
Merged

fix: Manully validate StreamPorts in StreamConfig to prevent empty values #11332

zhengkunwang223 merged 1 commit into from
Dec 15, 2025

Conversation

@HynoR
Copy link
Contributor

@HynoR HynoR commented Dec 15, 2025 •
edited
Loading

What this PR does / why we need it?

fix #11302
当前代码创建非tcpudp代理的网站，会因为streamport是空值导致验证错误
image

Summary of your change

改变该值，允许为空
在使用该值的地方加入空字符串校验，为空报错

Please indicate you've done the following:

  • Made sure tests are passing and test coverage is added if needed.
  • Made sure commit message follow the rule of Conventional Commits specification.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed.

@f2c-ci-robot
Copy link

f2c-ci-robot bot commented Dec 15, 2025

Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@f2c-ci-robot
Copy link

f2c-ci-robot bot commented Dec 15, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign zhengkunwang223 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@HynoR
Copy link
Contributor Author

HynoR commented Dec 15, 2025

@zhengkunwang223

@HynoR HynoR changed the title fix: Validate StreamPorts in StreamConfig to prevent empty values fix: Manully validate StreamPorts in StreamConfig to prevent empty values Dec 15, 2025
@zhengkunwang223 zhengkunwang223 merged commit 191396c into 1Panel-dev:dev-v2 Dec 15, 2025
0 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ssongliu ssongliu Awaiting requested review from ssongliu

@zhengkunwang223 zhengkunwang223 Awaiting requested review from zhengkunwang223

Assignees

No one assigned

Labels

do-not-merge/release-note-label-needed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@HynoR @zhengkunwang223